[Webkit-unassigned] [Bug 69834] [GStreamer] WebAudio AudioFileReader implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69834





--- Comment #35 from Philippe Normand <pnormand at igalia.com>  2012-01-17 01:04:50 PST ---
(In reply to comment #34)
> View in context: https://bugs.webkit.org/attachment.cgi?id=111782&action=review
> 
> > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:319
> > +        g_main_context_iteration(0, FALSE);
> 
> While I'm reading your patches (and conversation history with mrobinson), it came to me a question why you have not give a separate/dedicated context to "g_main_context_iteration". AFAIK, this will pop out a task from the work queue of the main thread if you give '0' to this API. 
> 
> Wouldn't it be clearer to create a new context (using g_main_context_new()) and pass the newly created context to the first argument of g_main_context_iteration()...?

I tried that at some point but it wasn't working well, I don't remember exactly what were the issues but if you can come up with a patch (in a new bugzilla entry) that uses a different context and works well, we can consider it :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.