[Webkit-unassigned] [Bug 69834] [GStreamer] WebAudio AudioFileReader implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69834


Dongwoo Joshua Im <dw.im at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dw.im at samsung.com




--- Comment #34 from Dongwoo Joshua Im <dw.im at samsung.com>  2012-01-16 22:16:06 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=111782&action=review

> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:319
> +        g_main_context_iteration(0, FALSE);

While I'm reading your patches (and conversation history with mrobinson), it came to me a question why you have not give a separate/dedicated context to "g_main_context_iteration". AFAIK, this will pop out a task from the work queue of the main thread if you give '0' to this API. 

Wouldn't it be clearer to create a new context (using g_main_context_new()) and pass the newly created context to the first argument of g_main_context_iteration()...?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.