[Webkit-unassigned] [Bug 76378] [EFL] Modify the code to webkit-style and adapt to C++ naming.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76378





--- Comment #5 from Ryuan Choi <ryuan.choi at samsung.com>  2012-01-16 17:21:32 PST ---
(From update of attachment 122636)
View in context: https://bugs.webkit.org/attachment.cgi?id=122636&action=review

In my quick scanning, almost is good.

> Source/WebKit/efl/ewk/ewk_tiled_model.cpp:711
> + * @param tileFreeCb function used to free tiles.

In previous point, we used Callback instead of Cb.
So, how about using same style?

> Source/WebKit/efl/ewk/ewk_view.cpp:242
> +#define EWK_VIEW_TYPE_CHECK(ewkView, ...)                                   \
> +    do {                                                                    \
> +        const char* _tmp_otype = evas_object_type_get(ewkView);             \
> +        const Evas_Smart* _tmp_s = evas_object_smart_smart_get(ewkView);    \
> +        if (EINA_UNLIKELY(!_tmp_s)) {                                       \
> +            EINA_LOG_CRIT                                                   \
> +                ("%p (%s) is not a smart object!", ewkView,                 \
> +                _tmp_otype ? _tmp_otype : "(null)");                        \
> +            return __VA_ARGS__;                                             \
> +        }                                                                   \
> +        const Evas_Smart_Class* _tmp_sc = evas_smart_class_get(_tmp_s);     \
> +        if (EINA_UNLIKELY(!_tmp_sc)) {                                      \
> +            EINA_LOG_CRIT                                                   \
> +                ("%p (%s) is not a smart object!", ewkView,                 \
> +                _tmp_otype ? _tmp_otype : "(null)");                        \
> +            return __VA_ARGS__;                                             \
> +        }                                                                   \
> +        if (EINA_UNLIKELY(_tmp_sc->data != EWK_VIEW_TYPE_STR)) {            \
> +            EINA_LOG_CRIT                                                   \
> +                ("%p (%s) is not of an ewk_view (need %p, got %p)!",        \
> +                ewkView, _tmp_otype ? _tmp_otype : "(null)",                \
> +                EWK_VIEW_TYPE_STR, _tmp_sc->data);                          \
> +            return __VA_ARGS__;                                             \
> +        }                                                                   \

IMO, your changelog is not enough because this is not naming change.

BTW, I want to know any reasons that these macro functions can't be changed to static inline functions.
and if not, I prefer only one space before \ 
I'll share this opinion to webkit-efl-dev.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.