[Webkit-unassigned] [Bug 76361] DFG should be able to do JS and custom getter caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76361





--- Comment #12 from Filip Pizlo <fpizlo at apple.com>  2012-01-16 16:55:03 PST ---
> Qt build not happy.

Should be fixed.  Turns out that the 32-bit build was not happy in general.

> 
> > Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:131
> > +            // FIXME: this is absurdly wrong.
> 
> (1) Yikes.
> 
> (2) Why don't you file a bug about what's wrong, and remove the FIXME.

Filed a radar.

> 
> > Source/JavaScriptCore/dfg/DFGOperations.cpp:835
> > +    CodeOrigin codeOrigin = stubInfo->codeOrigin;
> > +    while (codeOrigin.inlineCallFrame)
> > +        codeOrigin = codeOrigin.inlineCallFrame->caller;
> 
> Is this loop also absurdly wrong, as the loop above is?

Yup.

> 
> > Source/JavaScriptCore/dfg/DFGRepatch.cpp:283
> > +        // Need extra checks.
> 
> A "why" comment would be better here, explaining that non-flushing gets must be trivial values, because non-trivial values might call to C++ code and stomp on our non-flushed registers.

Added a better comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.