[Webkit-unassigned] [Bug 76361] DFG should be able to do JS and custom getter caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76361


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122678|review?                     |review+
               Flag|                            |




--- Comment #8 from Geoffrey Garen <ggaren at apple.com>  2012-01-16 14:39:31 PST ---
(From update of attachment 122678)
View in context: https://bugs.webkit.org/attachment.cgi?id=122678&action=review

r=me

Qt build not happy.

> Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:131
> +            // FIXME: this is absurdly wrong.

(1) Yikes.

(2) Why don't you file a bug about what's wrong, and remove the FIXME.

> Source/JavaScriptCore/dfg/DFGOperations.cpp:835
> +    CodeOrigin codeOrigin = stubInfo->codeOrigin;
> +    while (codeOrigin.inlineCallFrame)
> +        codeOrigin = codeOrigin.inlineCallFrame->caller;

Is this loop also absurdly wrong, as the loop above is?

> Source/JavaScriptCore/dfg/DFGRepatch.cpp:283
> +        // Need extra checks.

A "why" comment would be better here, explaining that non-flushing gets must be trivial values, because non-trivial values might call to C++ code and stomp on our non-flushed registers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.