[Webkit-unassigned] [Bug 76378] [EFL] Modify the code to webkit-style and adapt to C++ naming.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 16 07:38:05 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76378
--- Comment #3 from JungJik Lee <jungjik.lee at samsung.com> 2012-01-16 07:38:05 PST ---
(In reply to comment #2)
> Looks fine, but small fix would be required.
>
> > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:1974
> > + const unsigned long column = info->col;
Done!
>
> Why don't you replace info with more meaningful term ?
>
> > Source/WebKit/efl/ewk/ewk_tiled_model.cpp:350
> > + render_start = (double)timev.tv_sec +
>
> Will you let render_start allow ?
Done!
>
> > Source/WebKit/efl/ewk/ewk_view.cpp:259
> > + Ewk_View_Private_Data* ptr = smartData->_priv
>
> Why don't you replace prt ?
Done!
But we still have many abbreviations and underscores. I am going to revise them occasionally and continually.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list