[Webkit-unassigned] [Bug 76336] [Texmap] TextureMapper creates two many big intermediate surfaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76336





--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-16 03:16:19 PST ---
(From update of attachment 122566)
View in context: https://bugs.webkit.org/attachment.cgi?id=122566&action=review

This seems so much more simple

> Source/WebCore/ChangeLog:11
> +        2. Avoid generatig intermediate surface for occasions where they're not necessary,

generating

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:281
> +    // We apply the transform that is generated to compensate for painting into a surface.

We apply the following transform to compensate for painting into a surface..

Maybe the last part could be described better

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:358
> +    return boundingRect(m_transform.combined().inverse());

will there always be an inverse?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:361
> +IntRect TextureMapperNode::boundingRect(const TransformationMatrix& matrix)

Maybe we should rename this method?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:389
> +    // Tested by compositing/reflections/reflection-opacity.html

I love these comments!

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:416
> +        // FIXME: blend the two if both exist.

Any test for that?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:458
> +    // If we painted the replica, the mask is already baked in so we don't need to paint it again.

included?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:463
> +    TransformationMatrix targetTransform = TransformationMatrix().multiply(options.transform).multiply(m_transform.combined()).translate(options.offset.width(), options.offset.height());

Maybe write this on a couple of lines

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.