[Webkit-unassigned] [Bug 75512] [EFL] Implement the hit test result's bounding rect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75512


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121385|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from MORITA Hajime <morrita at google.com>  2012-01-16 00:58:55 PST ---
(From update of attachment 121385)
View in context: https://bugs.webkit.org/attachment.cgi?id=121385&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:691
> +    hitTest->bounding_box = result.innerNonSharedNode() ? result.innerNonSharedNode()->renderer()->absoluteBoundingBoxRect() : WebCore::IntRect();

I know you just follow what other ports do. But it is really unfortunate to see this
- layering violation: accessing the render object.
- null check which should be done by HItTestResult.

Could you extract this function as a part of HistTestResult method?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.