[Webkit-unassigned] [Bug 76035] Add state attribute to history's dom interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76035


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122518|review?                     |review-
               Flag|                            |




--- Comment #23 from Brady Eidson <beidson at apple.com>  2012-01-13 16:50:58 PST ---
(From update of attachment 122518)
View in context: https://bugs.webkit.org/attachment.cgi?id=122518&action=review

>> Source/WebCore/page/History.cpp:116
>> +            ScriptValue& state = historyItem->deserializedStateObject();
> 
> This is kind of subtle given that you're assign to a non-const reference.
> 
> Maybe you should have historyItem do this work?

Not maybe - definitely!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.