[Webkit-unassigned] [Bug 76274] [chromium] Refactor canvas, plugin, and video drawing to be more data-driven

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 13 15:00:13 PST 2012


--- Comment #9 from Adrienne Walker <enne at google.com>  2012-01-13 15:00:13 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 122458 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=122458&action=review
> > 
> > Looks reasonable. R=me but can't land as is (feel free to ask any committer for help with landing the final version)
> I'll get it.

Actually, scratch that.  It looks like this fails the webkit_unit_tests target in CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers.  We've got a test that looks like it's expecting the CCLayerImpl::draw() function to be called via this custom layer path.  Removing the code out of CCLayerImpl::appendQuads makes this test fail, although I think that's the right thing to do.

I suspect maybe you need to just change the draw function in the BlendStateCheckLayer test class to an appendQuads function and verify that a CCDrawQuad with that sharedQuadState has the right needsBlending() setting, rather than testing the context itself.

tdresser: Can you see if you can fix this failure and resubmit a patch (also without the string OOPS anywhere in the ChangeLog)?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list