[Webkit-unassigned] [Bug 76266] Cache RenderStyle pointer in updateBoxModelInfoFromStyle methods

Fri Jan 13 05:34:49 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=76266

Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122410|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #2 from Andreas Kling <kling at webkit.org>  2012-01-13 05:34:49 PST ---
(From update of attachment 122410)
View in context: https://bugs.webkit.org/attachment.cgi?id=122410&action=review

> Source/WebCore/ChangeLog:8
> +        Refactoring code therefore no new tests. (OOPS!)

CQ can't land this automatically with the OOPS intact, you need to remove it.

Also, you should mention why we are doing this, as it's not obvious since RenderObject::style() is just a trivial inline getter right now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.