[Webkit-unassigned] [Bug 76264] Web Inspector: [InspectorIndexedDB] Add InspectorIndexedDBAgent and IndexedDBModel, pass database names to inspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76264


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122407|review?                     |review+
               Flag|                            |




--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2012-01-13 05:25:00 PST ---
(From update of attachment 122407)
View in context: https://bugs.webkit.org/attachment.cgi?id=122407&action=review

> Source/WebCore/inspector/Inspector.json:111
> +                    { "name": "securityOrigin", "type": "string", "description": "Frame document's security origin." },

Should we make this field optional?

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:110
> +        RefPtr<InspectorObject> result = InspectorObject::create();

You should use new generated API for front-end messages.

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:166
> +    m_enabled = true;

I don't introduce these unless performance matters.

> Source/WebCore/inspector/InspectorIndexedDBAgent.h:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/front-end/IndexedDBModel.js:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

2012

> Source/WebCore/inspector/front-end/IndexedDBModel.js:203
> +    

Extra blank line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.