[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #13 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-13 01:22:36 PST ---
(In reply to comment #9)
> (From update of attachment 122298 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122298&action=review
> 
> > Source/WebKit/qt/declarative/plugin.cpp:69
> > +        qmlRegisterUncreatableType<QtWebSecurityOrigin>(uri, 3, 0, "SecurityOrigin", QObject::tr("Cannot create separate instance of SecurityOrigin"));
> 
> Hey, just a nitpicking comment from my part. :)
> 
> I believe that if this is gonna sit in API/qt/ then you should follow the new naming convention and it should be called QWebSecurityOrigin. The same for the private class, cpp and header files.

As those classes are not exported in C++ sense, but only to QML, I think that Qt* actually makes more sense than using Q[A-Z]*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.