[Webkit-unassigned] [Bug 76190] [Qt] [PATCH] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 13 01:19:05 PST 2012


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |
                 CC|                            |hausmann at webkit.org

--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2012-01-13 01:19:05 PST ---
(In reply to comment #4)
> With such stupid rules I regret of spending a few hours to detect the issue :-(

I'm sorry Johannes that you feel that way, but this is just like in KDE or any other open source project: There are rules about contributing source code.

In KDE you have to understand SVN, write a descriptive commit message and adhere to BUG:12344 etc. standards for the bugzilla integration. Then you need to get yourself access to the KDE SVN repository or find a kind soul to review & commit the patch for you.

In the Git project you need to use git send-email to send your patch to the git list, CC Junio and make sure your commit has the right Signed-off-by.

In Qt you have to upload your patch to Gerrit and it needs to have a unique Change-Id, generated by a git commit hook.

And lastly in WebKit you upload your patch to Bugzilla together with a ChangeLog entry. The documentation at http://www.webkit.org/coding/contributing.html explains the necessary steps and the tools available make it easy to "play by the rules". But as you can see, every project has such rules.

If you do not want to play by those rules but still get your change contributed, then you need to approach a fellow developer with kind words asking him to do the "paperwork" on your behalf. In WebKit's case however you still need to do the initial patch upload to accept the contribution licensing agreement, but it is possible to get help for getting your patch reviewed and landed manually.

I'm re-opening this bug because the issue you discovered still appears to be valid, regardless of your feelings towards the patch contribution process of WebKit.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list