[Webkit-unassigned] [Bug 73215] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #9 from Jesus Sanchez-Palencia <jesus at webkit.org>  2012-01-12 13:46:04 PST ---
(From update of attachment 122298)
View in context: https://bugs.webkit.org/attachment.cgi?id=122298&action=review

> Source/WebKit/qt/declarative/plugin.cpp:69
> +        qmlRegisterUncreatableType<QtWebSecurityOrigin>(uri, 3, 0, "SecurityOrigin", QObject::tr("Cannot create separate instance of SecurityOrigin"));

Hey, just a nitpicking comment from my part. :)

I believe that if this is gonna sit in API/qt/ then you should follow the new naming convention and it should be called QWebSecurityOrigin. The same for the private class, cpp and header files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.