[Webkit-unassigned] [Bug 76190] [Qt] [PATCH] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 13:00:41 PST 2012


Alexander Færøy <ahf at 0x90.dk> changed:

           What    |Removed                     |Added
                 CC|                            |ahf at 0x90.dk

--- Comment #1 from Alexander Færøy <ahf at 0x90.dk>  2012-01-12 13:00:41 PST ---
(In reply to comment #0)
> Please use 'git am 0001-Use-Ok-and-Cancel-buttons-in-JavaScript-confirm-box.patch' to keep author information ...

The WebKit project doesn't work like that since the official repository is a subversion repository even though most of the QtWebKit developers uses the Git trees since we can actively work on QtWebKit without ever having to "git push" or "svn commit" because we have tons of automated review and commit tools :-)

Please have a look at http://trac.webkit.org/wiki/QtWebKitContrib and http://www.webkit.org/coding/contributing.html and upload a version of your patch that contains a proper ChangeLog entry :-)

> Maybe you should create a qtwebkit-patches mailing list for a quick and comfortable sending patches via 'git send-email' ...

Wont work since all patches must be reviewed of an approved WebKit reviewer and the reviewer tool is built into our Bugzilla setup :-)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list