[Webkit-unassigned] [Bug 76177] SVG group getBBox returns 0, 0, 0, 0 for a group of perpendicular paths

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76177





--- Comment #5 from Philip Rogers <pdr at google.com>  2012-01-12 11:12:53 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > It would be clearer if the uniteIfNonZero function used the isZero function rather than having a hand-written distinct implementation of “non-zero”. I am concerned that this function’s definition of 0 is !x, while FloatSize’s definition of 0 is fabs(x) < epsilon. It looks like Levi made that change to FloatSize in July and I am not sure why it’s not needed here as well.
> 
> It was definitely an oversight that this still uses zero instead of considering epsilon, let's correct that now. Of course, epsilon is not perfect either...

I agree and can do this. Should I do that in this review, or as a followup patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.