[Webkit-unassigned] [Bug 76177] SVG group getBBox returns 0, 0, 0, 0 for a group of perpendicular paths

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76177


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122241|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2012-01-12 11:03:24 PST ---
(From update of attachment 122241)
View in context: https://bugs.webkit.org/attachment.cgi?id=122241&action=review

> Source/WebCore/platform/graphics/FloatRect.cpp:114
> +    float left = min(x(), other.x());
> +    float top = min(y(), other.y());
> +    float right = max(maxX(), other.maxX());
> +    float bottom = max(maxY(), other.maxY());

The "l, t, r, b" or "left, top, right, bottom" naming is obsolete for IntRect and FloatRect. In new code we should name these things like x, y, maxX, and maxY.

> Source/WebCore/platform/graphics/FloatRect.cpp:119
>  void FloatRect::uniteIfNonZero(const FloatRect& other)

Not new to this patch:

It would be clearer if the uniteIfNonZero function used the isZero function rather than having a hand-written distinct implementation of “non-zero”. I am concerned that this function’s definition of 0 is !x, while FloatSize’s definition of 0 is fabs(x) < epsilon. It looks like Levi made that change to FloatSize in July and I am not sure why it’s not needed here as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.