[Webkit-unassigned] [Bug 76113] Reduce throttling on video-buffering-repaints-controls test to prevent timeout.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 10:24:35 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76113


Dale Curtis <dalecurtis at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dglazkov at chromium.org




--- Comment #6 from Dale Curtis <dalecurtis at chromium.org>  2012-01-12 10:24:35 PST ---
+dglazkov

The test uses a throttled http server to slow down loading of a local video. With the previous 10kb/s throttling the test was too slow and was hitting the global 6 sec test timeout on occasion. I've bumped this throttling from 10kb/s to 80kb/s.

I used a 10kb/s previously because it was the only way I had found to reduce flakiness. Too fast and the progress bar moves an indeterminate number of steps ahead before pixel snapshot is saved.

I also noticed some flaky failures during debugging, so I switched the test to check for repaints between the last progress event and the suspend event. Since this requires loading ~all of the file, the rate needed to be higher to prevent test timeouts.

The rate can't be made too fast though or the progress bar loads ~instantly and shows the correct status even on the old pre-buffering fix code. 80kb/s seems to be roughly the sweet spot.

I hope this explains the patch well enough for review. Thanks in advance!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list