[Webkit-unassigned] [Bug 67109] [EFL] Weak scroll feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67109


KwangHyuk <hyuki.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hyuki.kim at samsung.com




--- Comment #9 from KwangHyuk <hyuki.kim at samsung.com>  2012-01-12 06:59:55 PST ---
> Source/WebKit/efl/ewk/ewk_frame.cpp:77
> +        Eina_Bool enabled : 1;

Use bool type.

> Source/WebKit/efl/ewk/ewk_frame.cpp:79
> +        Eina_Bool moving_viewport_allowed : 1;

Ditto.
Check the name of variable.

> Source/WebKit/efl/ewk/ewk_frame.cpp:80
> +        Ecore_Idler *idler;

idler for what ?

> Source/WebKit/efl/ewk/ewk_frame.cpp:193
> +    smartData->queued_scrolls.enabled = EINA_FALSE;

Use false;

> Source/WebKit/efl/ewk/ewk_frame.cpp:194
> +    smartData->queued_scrolls.moving_viewport_allowed = EINA_TRUE;

Use true;

> Source/WebKit/efl/ewk/ewk_frame.cpp:294
> +    Ewk_Frame_Smart_Data *smartData = (Ewk_Frame_Smart_Data*) priv;

Use cpp-style type casting.

> Source/WebKit/efl/ewk/ewk_frame.cpp:295
> +    smartData->queued_scrolls.moving_viewport_allowed = EINA_FALSE;

Use false,

> Source/WebKit/efl/ewk/ewk_frame.cpp:297
> +    smartData->queued_scrolls.moving_viewport_allowed = EINA_TRUE;

Use true;

> Source/WebKit/efl/ewk/ewk_frame.cpp:747
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(smartData->view, EINA_FALSE);

Why don't use false ?

> Source/WebKit/efl/ewk/ewk_frame.cpp:750
> +        int visibleW, visibleH, scrollX, scrollY, scrollDeltaX, scrollDeltaY, frameW, frameH;

For the W,H, why don't you use Widht or Height ?

> Source/WebKit/efl/ewk/ewk_frame.cpp:751
> +        ewk_frame_visible_content_geometry_get(ewkFrame, EINA_FALSE, 0, 0, &visibleW, &visibleH);

use false,

> Source/WebKit/efl/ewk/ewk_frame.cpp:779
> +                smartData->queued_scrolls.idler = ecore_idler_add(_ewk_frame_queued_scrolls_process_cb, smartData);

I couldn't make sure idler would be good for scroll operation ?
It may hardly have a chance to get a time slice.

> Source/WebKit/efl/ewk/ewk_frame.cpp:782
> +        return EINA_TRUE;

Use true or false,

> Source/WebKit/efl/ewk/ewk_frame.cpp:804
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(smartData->frame, EINA_FALSE);

Use true or false,

> Source/WebKit/efl/ewk/ewk_frame.cpp:806
> +        return EINA_TRUE;

Ditto,

> Source/WebKit/efl/ewk/ewk_frame.cpp:809
> +    return EINA_TRUE;

Ditto,

> Source/WebKit/efl/ewk/ewk_frame.cpp:814
> +    EWK_FRAME_SD_GET_OR_RETURN(ewkFrame, smartData, EINA_FALSE);

Ditto,

> Source/WebKit/efl/ewk/ewk_frame.cpp:820
> +    EWK_FRAME_SD_GET_OR_RETURN(ewkFrame, smartData, EINA_FALSE);

Ditto.

> Source/WebKit/efl/ewk/ewk_frame.h:624
> +EAPI Eina_Bool    ewk_frame_scroll_policy_set(Evas_Object *o, Eina_Bool queue_scrolls);

Check whether there is tab between Eina_Bool and API name.

> Source/WebKit/efl/ewk/ewk_frame.h:633
> +EAPI Eina_Bool    ewk_frame_scroll_policy_get(const Evas_Object *o);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.