[Webkit-unassigned] [Bug 75958] nrwt should use multiple http shards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75958


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122223|review+, commit-queue+      |review-, commit-queue-
               Flag|                            |




--- Comment #8 from Csaba Osztrogonac <ossy at webkit.org>  2012-01-12 06:28:29 PST ---
(From update of attachment 122223)
r-, because it broke a unittest. :-/

ERROR: test_shard_by_dir (webkitpy.layout_tests.controllers.manager_unittest.ShardingTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py", line 82, in test_shard_by_dir
    locked, unlocked = self.get_shards(num_workers=2, fully_parallel=False)
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py", line 79, in get_shards
    return self.manager._shard_tests(test_list, num_workers, fully_parallel)
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 593, in _shard_tests
    return self._shard_by_directory(test_files, num_workers)
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 664, in _shard_by_directory
    'locked_shard'),
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 706, in _resize_shards
    num_old_per_new = divide_and_round_up(len(old_shards), max_new_shards)
  File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 695, in divide_and_round_up
    return int(math.ceil(float(numerator) / divisor))
TypeError: unsupported operand type(s) for /: 'float' and 'Mock'

Could you check it and fix?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.