[Webkit-unassigned] [Bug 75883] [Qt][WK2] WebProcesses crashes when composited reflections/masks are present

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 01:50:22 PST 2012


--- Comment #10 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-12 01:50:22 PST ---
(From update of attachment 122123)
View in context: https://bugs.webkit.org/attachment.cgi?id=122123&action=review

> Source/WebCore/ChangeLog:14
> +        2. Rename TextureMapperNode::texture() to getFirstContentTextureForMask(), and allow the
> +           texture to come from the externally-managed tiles.

isn't the word find* more used for this? like findFirstContentTextureForMask?

> Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:34
> +        // A texture that's not used would have two references - the reference inside the vector, and the "texture" local variable.

unused? but the comment is confusing as you check for > 2

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:129
> -    virtual void releaseTextureToPool(BitmapTexture* surface);
>      virtual PassRefPtr<BitmapTexture> acquireTextureFromPool(const IntSize&);

Maybe add a comment here about how they are released.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list