[Webkit-unassigned] [Bug 63608] [EFL][WK2] Add ModuleEfl.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63608





--- Comment #9 from Andreas Kling <kling at webkit.org>  2012-01-12 00:45:39 PST ---
(From update of attachment 121985)
View in context: https://bugs.webkit.org/attachment.cgi?id=121985&action=review

> Source/WebKit2/Platform/efl/ModuleEfl.cpp:33
> +    m_module = eina_module_new(m_path.utf8().data());
> +    if (m_module && eina_module_load(m_module))
> +        return true;
> +
> +    return false;

If eina_module_load() fails, don't you need to call eina_module_free() before returning false?

> Source/WebKit2/Platform/efl/ModuleEfl.cpp:41
> +    if (m_module) {
> +        eina_module_unload(m_module);
> +        m_module = 0;
> +    }

Is it safe to call eina_module_unload() here if m_module is non-null, but eina_module_load() failed in Module::load()?

> Source/WebKit2/Platform/efl/ModuleEfl.cpp:47
> +    if (m_module)
> +        return eina_module_symbol_get(m_module, functionName);

Is it safe to call eina_module_symbol_get() here if m_module is non-null, but eina_module_load() failed in Module::load()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.