[Webkit-unassigned] [Bug 75553] [GTK][WK2] Initial FullScreen support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75553





--- Comment #17 from Philippe Normand <pnormand at igalia.com>  2012-01-12 00:44:28 PST ---
(In reply to comment #16)
> (From update of attachment 121284 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121284&action=review
> 
> Not a full review, but here are a few things I noticed.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:80
> > +#if ENABLE(FULLSCREEN_API)
> > +    RefPtr<FullScreenWindowController> fullScreenWindowController;
> > +#endif
> >  };
> 
> This doesn't actually need to be allocated on the heap. You can just do:
> FullScreenWindowController fullScreenWindowController;
> 
> Be sure that it's still noncopyable though.
> 

Hum yes but the WebFullScreenManagerProxyGtk needs access to the FullScreenWindowController. If I make it noncopyable and not allocated on the heap I get this error:


../../Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h: In member function ‘void WebKit::WebFullScreenManagerProxy::enterFullScreen()’:
../../Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h:32:14: error: ‘FullScreenWindowController::FullScreenWindowController(const FullScreenWindowController&)’ is private
../../Source/WebKit2/UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:48:100: error: within this context
../../Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h: In member function ‘void WebKit::WebFullScreenManagerProxy::exitFullScreen()’:
../../Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h:32:14: error: ‘FullScreenWindowController::FullScreenWindowController(const FullScreenWindowController&)’ is private

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.