[Webkit-unassigned] [Bug 75812] JSC should be a triple-tier VM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75812


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #15 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-01-11 21:11:26 PST ---
Attachment 122163 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Last 3072 characters of output:
ec is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/llint/LLIntHelpers.cpp:114:  __cce_pc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/llint/LLIntHelpers.cpp:120:  __cr_exec is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/llint/LLIntHelpers.cpp:121:  __cr_pc is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/llint/LLIntHelpers.cpp:122:  __cr_callTarget is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/JavaScriptCore/llint/LLIntHelpers.cpp:1087:  The parameter name "v" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/llint/LLIntHelpers.cpp:1120:  The parameter name "!" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:43:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:65:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/jit/HostCallReturnValue.cpp:38:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/HostCallReturnValue.cpp:44:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/HostCallReturnValue.cpp:46:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/HostCallReturnValue.cpp:52:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/jit/HostCallReturnValue.cpp:54:  Extra space before ( in function call  [whitespace/parens] [4]
Source/JavaScriptCore/jit/HostCallReturnValue.cpp:65:  The parameter name """" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/StructureChain.h:40:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/JavaScriptCore/runtime/JSVariableObject.h:41:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/runtime/JSTypeInfo.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/JavaScriptCore/runtime/Structure.h:48:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 27 in 79 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.