[Webkit-unassigned] [Bug 76023] Update and show ewk_view with updated webpage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76023





--- Comment #4 from EunMi Lee <eunmi15.lee at samsung.com>  2012-01-11 19:01:56 PST ---
Thanks for your comments :)

(In reply to comment #2)
> (From update of attachment 121972 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121972&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:60
> > -    evas_object_image_data_update_add(m_viewObject, rect.x(), rect.y(), rect.width(), rect.height());
> > +    ewk_view_display(m_viewObject, rect);
> 
> Patch itself is good, but you should rebase this because m_viewObject is renamed.
=> Rebased.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_private.h:32
> > +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect);
> > +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size);
> 
> Should we return Eina_Bool?
=> No, because those APIs are internal private API. so, I've changed Eina_Bool to bool type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.