[Webkit-unassigned] [Bug 76023] Update and show ewk_view with updated webpage.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 11 18:33:36 PST 2012


--- Comment #2 from Ryuan Choi <ryuan.choi at samsung.com>  2012-01-11 18:33:36 PST ---
(From update of attachment 121972)
View in context: https://bugs.webkit.org/attachment.cgi?id=121972&action=review

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:60
> -    evas_object_image_data_update_add(m_viewObject, rect.x(), rect.y(), rect.width(), rect.height());
> +    ewk_view_display(m_viewObject, rect);

Patch itself is good, but you should rebase this because m_viewObject is renamed.

> Source/WebKit2/UIProcess/API/efl/ewk_private.h:32
> +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect);
> +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size);

Should we return Eina_Bool?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list