[Webkit-unassigned] [Bug 73215] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-11 12:39:00 PST ---

> Maybe you could use SchemeRegistry::shouldTreatURLSchemeAsLocal, not sure if this alone is enough.

This might need some fixes for qrc: ?

> 
> > Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:77
> > +        s_localSchemes << QLatin1String("file") << QLatin1String("qrc");
> 
> I believe you don't need to do this... we already have code inside WebCore to deal with local schemes.

Same here

> 
> > Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:32
> > +class QWEBKIT_EXPORT QtWebSecurityOrigin : public QObject {
> 
> I believe the naming is incorrect here, the others start with Q prefix instead of Qt, but I see that we already have QWebSecurityOrigin. Maybe someone else has a suggestion how to fix this, I don't know.

Basically everything publically exposed via C++ starts with Q, everything else starts with Qt. This is unfortunately not consistent in our code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.