[Webkit-unassigned] [Bug 76064] [CSSRegions]Add back region style code removed in r104036

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 11 10:25:01 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76064





--- Comment #2 from Tony Chang <tony at chromium.org>  2012-01-11 10:25:01 PST ---
(From update of attachment 122038)
View in context: https://bugs.webkit.org/attachment.cgi?id=122038&action=review

Just some nits, Hyatt should do the actual review.  Can you upload a patch that applies to tip-of-tree so the ews bots will run?

> Source/WebCore/css/CSSStyleSelector.cpp:220
> +    RuleSet(bool regionStyleRule = false);

explicit.  Also, I think passing in an enum would make the calling code easier to read and could be used in addMatchedDeclaration and RuleData.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list