[Webkit-unassigned] [Bug 75652] Inconsistent text selection behavior with option-shift-left/right

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 11 09:30:24 PST 2012


--- Comment #4 from Enrica Casucci <enrica at apple.com>  2012-01-11 09:30:24 PST ---
(From update of attachment 121960)
View in context: https://bugs.webkit.org/attachment.cgi?id=121960&action=review

> Source/WebCore/ChangeLog:14
> +

There is no description of what the fix is. You should also provide some information of there changes to each file.

> Source/WebCore/editing/FrameSelection.cpp:943
> +            // behavior when, for instance, word-selecting backwards starting with the caret on

typo "on". Should be "in". You should provide some of this information in the ChangeLog.

> Source/WebCore/editing/FrameSelection.cpp:946
> +            VisibleSelection testSelection(m_selection);

This is a non descriptive variable name. I would rather use newSelection.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list