[Webkit-unassigned] [Bug 75462] Split GraphicsContext3DOpenGL into several files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75462





--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-11 01:44:49 PST ---
(From update of attachment 121866)
View in context: https://bugs.webkit.org/attachment.cgi?id=121866&action=review

> Source/WebCore/ChangeLog:13
> +
> +        Split GraphicsContext3DOpenGL.cpp into
> +        GraphicsContext3DOpenGLCommon.cpp, GraphicsContext3DOpenGL.cpp & GraphicsContext3DOpenGLES.cpp.
> +        Most of common APIs between gl and gles are in GraphicsContext3DOpenGLCommon.cpp.
> +        The other gl and gles specific APIs are placed apart in GraphicsContext3DOpenGL.cpp & GraphicsContext3DOpenGLES.cpp
> +
> +        No new tests required.

It would be good if you could write why this is an advantage. Also can you try to keep the lines shorter (around 80-100 chars)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.