[Webkit-unassigned] [Bug 75867] Compilation errors on build-webkit --debug --no-video --no-fullscreen-api on mac.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75867


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121911|review?                     |review-
               Flag|                            |




--- Comment #8 from Philippe Normand <pnormand at igalia.com>  2012-01-11 00:36:25 PST ---
(From update of attachment 121911)
View in context: https://bugs.webkit.org/attachment.cgi?id=121911&action=review

Can you please elaborate the ChangeLog entries instead of copy/pasting the same message?

> Source/WebCore/rendering/RenderThemeMac.h:176
> -#endif
> -    
>      virtual bool shouldShowPlaceholderWhenFocused() const;
> +#endif

I might be wrong here, but I think this method was added under the wrong guard in the first place. It's used only in the HTMLTextFormControlElement from what I can tell, which has nothing to do with VIDEO.

> Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:947
> +void WebChromeClient::fullScreenRendererChanged(RenderBox* renderer)

This method should not be under VIDEO, it is guarded by FULLSCREEN_API in ChromeClient.h.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.