[Webkit-unassigned] [Bug 73545] [GStreamer] FFTFrame implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73545





--- Comment #8 from Philippe Normand <pnormand at igalia.com>  2012-01-11 00:11:13 PST ---
(In reply to comment #6)
> View in context: https://bugs.webkit.org/attachment.cgi?id=121865&action=review
> 
> Great job!
> 
> Here's some minor comments.
> 
> > Source/WebCore/platform/audio/FFTFrame.h:53
> > +#include <gst/fft/gstfft.h>
> 
> I guess this looks redundant as "gstfftf32.h" includes "gstfft.h" recursively.
> 

Hum, yes, probably :)

> > Source/WebCore/platform/audio/FFTFrameStub.cpp:32
> > +#if !OS(DARWIN) && !USE(WEBAUDIO_MKL) && !USE(WEBAUDIO_FFMPEG) && !USE(GSTREAMER)
> 
> I think you'd better use "WEBAUDIO" prefix, such as WEBAUDIO_GSTREAMER.

Right, I guess it'd be useful for ports using GStreamer and using a different lib for FFT processing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.