[Webkit-unassigned] [Bug 63608] [EFL][WK2] Add ModuleEfl.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63608





--- Comment #6 from YoungTaeck Song <youngtaeck.song at samsung.com>  2012-01-10 22:20:26 PST ---
(In reply to comment #5)
> (From update of attachment 120927 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120927&action=review
> 
> > Source/WebKit2/Platform/efl/ModuleEfl.cpp:51
> > +    void* symbolPointer = 0;
> > +
> > +    if (m_module)
> > +        symbolPointer = eina_module_symbol_get(m_module, functionName);
> > +
> > +    return symbolPointer;
> 
> Almost looks good to me.
> 
> As small thing, below is clear for me.
> if (m_module)
>     return eina_module_symbol_get(m_module, functionName);
> 
> return 0;

Sorry. I don't agree with you. because platformFunctionPointer relies on the eina_module_symbol_get, My code is more clear.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.