[Webkit-unassigned] [Bug 75973] Web Inspector: DOMAgent.getDocument should take an optional frameId argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75973





--- Comment #3 from Pavel Feldman <pfeldman at chromium.org>  2012-01-10 21:45:43 PST ---
(In reply to comment #2)
> I don't think the combined tree needs to change. We would need to include the document nodes under frames (so iframe -> document -> html).

That is in my immediate plans.

 If you ask for a document for a subframe you get that whole subtree. The UI would just know to skip the document node when expanding a subframe.
> 
> That, IMHO, would be the simplisest way to do this.

What is your user scenario then? Note that DOMAgent.getDocument is unique in a sense that it returns the node. All other methods are requesting that nodes are pushed to the client (requestChildNodes, etc.). Backend will not send the node to the front-end if it knows front-end already has it. So requirement for DOMAgent.getDocument(frameId) to work is equivalent to splitting the document in my mind.

I suspect there is a workaround for what you need without involving frame id:

RuntimeAgent.evaluate("frames[1].document", function(error, result) {
    DOMAgent.requestNode(result, function(error, nodeId) {
        var node = WebInspector.domAgent.nodeForId(nodeId);
    });
});

I.e. you get a javascript wrapper for the node you need and then convert it into the DOM terms.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.