[Webkit-unassigned] [Bug 73544] [EFL] Add Web Notification feature for WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #31 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-01-10 20:55:21 PST ---
(From update of attachment 121963)
View in context: https://bugs.webkit.org/attachment.cgi?id=121963&action=review

> Source/WebKit/efl/ewk/ewk_notification.h:40
> + * Get iconURL for the notification from @c Ewk_Notification.

s/Get/Gets/g

> Source/WebKit/efl/ewk/ewk_notification.h:49
> + * Get title for the notification from @c Ewk_Notification.

s/Get/Gets/g

> Source/WebKit/efl/ewk/ewk_notification.h:55
> +EAPI char* ewk_notification_title_get(Ewk_Notification* eni);

We have added *const* keyword to parameter of _get function. And also, we follow efl coding style in public header file. So, move * to function side.

> Source/WebKit/efl/ewk/ewk_notification.h:64
> +EAPI char* ewk_notification_body_get(Ewk_Notification* eni);

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:75
> +EAPI char* ewk_notification_html_url_get(Ewk_Notification* eni);

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:84
> +EAPI char* ewk_notification_dir_get(Ewk_Notification* eni);

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:114
> +EAPI void ewk_notification_ondisplay_event_send(Ewk_Notification* eni);

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:121
> +EAPI void ewk_notification_onclick_event_send(Ewk_Notification* eni);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.