[Webkit-unassigned] [Bug 75996] New: Typo in sample-accurate-scheduling layout test?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75996

           Summary: Typo in sample-accurate-scheduling layout test?
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Audio
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rtoy at chromium.org
                CC: crogers at google.com


In the sample-accurate-scheduling test line 106 is:

var timeInSeconds = sampleOffsets[i] * sampleRate;

I think this should probably be divide instead of multiply if sampleOffsets[i] really means a sample offset.  If we change this to divide, then the test fails.  I think the problem is that noteOn takes a float, so we convert the double from javascript to a float for the idl and then to a double inside the webaudio code.  This conversion loses precision and the sample offset is off by one.  We should change noteOn to take a double or maybe change the code that converts the time to sample to round instead of truncate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.