[Webkit-unassigned] [Bug 19472] test for dynamic changes to the "data" attribute of an OBJECT element fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19472





--- Comment #9 from Darin Adler <darin at apple.com>  2012-01-10 10:25:57 PST ---
(From update of attachment 111948)
View in context: https://bugs.webkit.org/attachment.cgi?id=111948&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:203
> +void HTMLPlugInImageElement::updateWidgetTimerFired(Timer<HTMLPlugInImageElement> *)

Incorrect formatting here. Space before * should be omitted.

> Source/WebCore/html/HTMLPlugInImageElement.cpp:205
> +    m_updateWidgetTimer.stop();

No need to stop the timer; it’s a one-shot.

> Source/WebCore/html/HTMLPlugInImageElement.h:61
> +    Timer<HTMLPlugInImageElement> m_updateWidgetTimer;

A timer is a large object. This means we’re consuming a lot more memory. Is there a way to do this without the timer?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.