[Webkit-unassigned] [Bug 75695] [EFL] Add IntRect(const Eina_Rectangle*) constructor.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75695





--- Comment #4 from KwangHyuk <hyuki.kim at samsung.com>  2012-01-10 10:06:13 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 121840 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=121840&action=review
> > 
> > > Source/WebCore/platform/graphics/IntRect.h:192
> > >      explicit IntRect(const Eina_Rectangle&);
> > > +    explicit IntRect(const Eina_Rectangle*);
> > 
> > This looks like a bad idea to me, it would be better to update call sites to dereference the Eina_Rectangle* so they can go through the Eina_Rectangle& constructor, e.g:
> > WebCore::IntRect rect(*area);
> Yes,It might be the reason why other ports didn't add pointer type.
> Ok, I will try it.
> 
> 
> > The problem with either approach is that you have no handling of null Eina_Rectangle*, but I suppose that's something for the call sites to know about.
> I have considered handling of null.
> But, as far as I know, WebCore doesn't like null handling for every cases. :)

"WebCore doesn't like null handling for every cases." meant "WebCore doesn't seem to force it to check null for every cases." :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.