[Webkit-unassigned] [Bug 75883] [Qt][WK2] WebProcesses crashes when composited reflections/masks are present

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75883





--- Comment #3 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-01-10 06:52:02 PST ---
(In reply to comment #2)
> (From update of attachment 121733 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121733&action=review
> 
> > Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:254
> > +        HashMap<int, ExternallyManagedTile>::iterator mapEnd = m_externallyManagedTiles.end();
> > +        for (HashMap<int, ExternallyManagedTile>::iterator mapIterator = m_externallyManagedTiles.begin(); mapIterator != mapEnd; ++mapIterator) {
> 
> I think using 'end' and 'it' would be sufficient. Very common pattern in webkit
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:382
> > +
> > +    if (layer)
> > +        toWebGraphicsLayer(layer)->setLayerTreeTileClient(layerTreeTileClient());
> 
> you dont need to setSize here? like in setMaskLayer?

No, since reflection layers don't have content (they always draw their parent's content).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.