[Webkit-unassigned] [Bug 72589] [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72589





--- Comment #29 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-01-10 00:19:06 PST ---
(From update of attachment 121688)
View in context: https://bugs.webkit.org/attachment.cgi?id=121688&action=review

It looks good to me, great work!. I have just a few more comments, sorry :-P

> Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp:33
> +int
> +main(int argc, char** argv)

This should be one line.

> Tools/Scripts/run-gtk-tests:77
> +        for path in paths_to_check:
> +            filepath = os.path.join(exec_prefix, path, filename)
> +            if os.path.isfile(filepath):
> +                return filepath
> +            return None

You are only checking the first path, the return should be after the loop.

> Tools/Scripts/run-gtk-tests:97
> +        Executive().popen(["xprop", "-root", "-remove", "AT_SPI_BUS"],
> +                          env=test_env, stderr=subprocess.PIPE, stdout=subprocess.PIPE)

Don't use pipes if you are not going to read/write from/to them

> Tools/Scripts/run-gtk-tests:105
> +                a11y_bus_launcher = Executive().popen([a11y_bus_launcher_path],
> +                                                      env=test_env, stderr=subprocess.PIPE, stdout=subprocess.PIPE)

Ditto.

> Tools/Scripts/run-gtk-tests:116
> +                a11y_registryd = Executive().popen(["%s/at-spi2-registryd" % atspi2_exec_path],
> +                                                   env=test_env, stderr=subprocess.PIPE, stdout=subprocess.PIPE)

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.