[Webkit-unassigned] [Bug 75302] ShadowContentElement should be able to use query.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 9 19:43:29 PST 2012


--- Comment #18 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-01-09 19:43:28 PST ---
(From update of attachment 121775)
View in context: https://bugs.webkit.org/attachment.cgi?id=121775&action=review


> Source/WebCore/dom/ShadowContentElement.cpp:46
> +    , m_select(select)

And that's it? What about changing attribute value? Shouldn't that also reset m_select?

> Source/WebCore/dom/ShadowContentElement.h:46
> +    static PassRefPtr<ShadowContentElement> create(Document*, const String& select = String());

Can we just eliminate the implicit param? It seem too clever.

> Source/WebCore/dom/ShadowContentElement.h:57
> +    // FIXME: Currently this constructor accepts wider query than shadow dom spec.

File a bug and list it here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list