[Webkit-unassigned] [Bug 75789] defineOwnProperty not implemented for Array objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75789


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #121704|review?                     |review+
               Flag|                            |




--- Comment #5 from Sam Weinig <sam at webkit.org>  2012-01-09 12:17:56 PST ---
(From update of attachment 121704)
View in context: https://bugs.webkit.org/attachment.cgi?id=121704&action=review

> Source/JavaScriptCore/JavaScriptCore.exp:5
> +__ZN3JSC7JSArray17defineOwnPropertyEPNS_8JSObjectEPNS_9ExecStateERKNS_10IdentifierERNS_18PropertyDescriptorEb
> +__ZN3JSC7JSArray9setLengthEjb
>  _JSCheckScriptSyntax
>  _JSClassCreate
>  _JSClassRelease

Please sort this.

> Source/JavaScriptCore/runtime/JSArray.cpp:261
> +    JSValue value = WriteBarrier<Unknown>::get();

Can you add a typedef of WriteBarrier<Unknown> to Base to make this cleaner.

> Source/JavaScriptCore/runtime/JSArray.h:81
> +            m_flags = (Flags)(m_flags | LengthIsReadOnly);

This should be a static cast.

> Source/JavaScriptCore/runtime/PropertyDescriptor.h:70
> +        unsigned attributesOverridingCurrent(const PropertyDescriptor& current) const;
>      private:

Please put a newline after this function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.