[Webkit-unassigned] [Bug 75789] defineOwnProperty not implemented for Array objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75789





--- Comment #3 from Gavin Barraclough <barraclough at apple.com>  2012-01-09 11:50:44 PST ---
(From update of attachment 121704)
View in context: https://bugs.webkit.org/attachment.cgi?id=121704&action=review

> Source/JavaScriptCore/runtime/JSArray.cpp:405
> +        // FIXME: this call to attributes will make absent attributes 

Ooops, this comment is incomplete. The code is safe, put a little conservative in the case of reconfiguring existing properties.
I think the call to attributes will pessimistically assume that if attributes are missing then they'll default to false – however if the property currently exists missing attributes will override from their current 'true' state (i.e. defineOwnProperty could be used to set a value without needing to entering 'SparseMode').

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.