[Webkit-unassigned] [Bug 72589] [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 9 10:55:13 PST 2012


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #121681|0                           |1
        is obsolete|                            |
 Attachment #121681|review?                     |
               Flag|                            |
 Attachment #121688|                            |review?
               Flag|                            |

--- Comment #27 from Mario Sanchez Prada <msanchez at igalia.com>  2012-01-09 10:55:13 PST ---
Created an attachment (id=121688)
 --> (https://bugs.webkit.org/attachment.cgi?id=121688&action=review)
Patch proposal

New patch avoiding the errors triggered by the last one...

(In reply to comment #25)
> Attachment 121681 [details] did not pass style-queue:
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit2/ChangeLog', u..." exit_code: 1
> WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBaseAccessible.h"
> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:53:  Missing space before ( in if(  [whitespace/parens] [5]
> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:84:  Missing space after ,  [whitespace/comma] [3]
> Total errors found: 2 in 22 files
> If any of these errors are false positives, please file a bug against check-webkit-style.

Forgot to run check-webkit-style before uploading the patch. Sorry!

(In reply to comment #26)
> (From update of attachment 121681 [details])
> Attachment 121681 [details] did not pass gtk-ews (gtk):
> Output: http://queues.webkit.org/results/11184581

ATSPI2 is an optional dependency, and in this case it's failing to build in the EWS because the package is there, but its version is not recent enough. In that case, the configure script should just say that ATSPI2 is not available and continue, instead of stopping there. Fixed in this new patch as well.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list