[Webkit-unassigned] [Bug 75466] Remove style warning in GraphicsContext3DOpenGL.cpp
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 7 18:18:49 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=75466
--- Comment #9 from Daniel Bates <dbates at webkit.org> 2012-01-07 18:18:49 PST ---
(From update of attachment 121076)
View in context: https://bugs.webkit.org/attachment.cgi?id=121076&action=review
I know this was already reviewed and landed, but I noticed a correctness issue.
> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1251
> + OwnArrayPtr<GLchar> info = adoptArrayPtr(static_cast<GLchar*>(fastMalloc(length)));
This is incorrect when GLOBAL_FASTMALLOC_NEW is disabled. We should be using operator new[] instead of fastMalloc() here since OwnArrayPtr ultimately uses operator delete[] on destruction.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list