[Webkit-unassigned] [Bug 75759] Web Inspector: Missing Implementation of Public InspectorDOMAgent Function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 6 22:40:09 PST 2012


--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2012-01-06 22:40:09 PST ---
(In reply to comment #0)
> • InspectorDOMAgent::searchingForNodeInPage is missing an implementation.
> • We should also make setSearchingForNodeInPage public.

This change is wrong. I was putting a lot of effort into breaking the: WebKit -> InspectorController -> agents control flows. As of now, only front-end should talk to the agents for control. Acting that way we don't need to sync front-end 'inspect mode' state with backend's 'searching for node'. The getter in the header should have been removed along with its implementation (my oversight), while setter should remain private.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list