[Webkit-unassigned] [Bug 70107] Custom written CSS lexer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70107





--- Comment #44 from Oliver Hunt <oliver at apple.com>  2012-01-06 13:50:17 PST ---
(From update of attachment 121239)
View in context: https://bugs.webkit.org/attachment.cgi?id=121239&action=review

> Source/WebCore/css/CSSParser.cpp:7494
> +        if (UNLIKELY(*data < 14 && (!*data || *data == 10 || (*data | 0x1) == 13))) {
> +            // String parsing is failed for character 0, 10, 12 or 13.
> +            return 0;
> +        }

yucky constants -- could you use '\n' etc? e.g. *data <= '\r' (i think?), etc

> Source/WebCore/css/CSSParser.cpp:7561
> +        ASSERT(*m_data >= 14 || (*m_data <= 9 && *m_data) || *m_data == 11);

more nasty constants

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.