[Webkit-unassigned] [Bug 75712] NRWT mysteriously exits when Apache returns an error code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75712





--- Comment #4 from Dirk Pranke <dpranke at chromium.org>  2012-01-06 13:05:05 PST ---
(In reply to comment #3)
> (From update of attachment 121444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121444&action=review
> 
> >> Tools/Scripts/webkitpy/layout_tests/port/base.py:240
> >> +                _log.error("httpd returned an error code. Cannot run http tests.")
> > 
> > Nit: can you rephrase this to give a little context to what we were doing? something like "checking if httpd works failed (httpd returned an error code). Cannot run http tests".
> 
> I'm having a hard time coming up with a way of phrasing this in a clear way. What value does the extra context contribute? The user tried to run http tests, and httpd failed, so we can't run them. It seems pretty clear even if you don't know that we were just trying to see if httpd exists.

The problem (confusion?) I'm seeing is that the user isn't actually trying to run http tests at that point (we're still checking system dependencies), and may not have actually specified anything specific about http (could just be running all tests).

How about "httpd seems broken. Cannot run system tests."? "seems broken" seems a little more informative to me than "returned an error code", in that it's saying there's something very wrong (it's not like httpd -v should normally fail).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.