[Webkit-unassigned] [Bug 70699] [WK2][GTK] Each test takes roughly half a second to load

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 6 01:07:19 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=70699





--- Comment #4 from Zan Dobersek <zandobersek at gmail.com>  2012-01-06 01:07:19 PST ---
(In reply to comment #3)
> Nice detective work! Might want to poke Sam or Anders on IRC to confirm that the Mac port isn't doing anything special. It could just be a difference in the version of SQLite that WebKit is using.

I've looked into that and found that the Mac port is indeed setting a different cache directory for testing. For DumpRenderTree, the Mac port sets the WebKitLocalCacheDefaultsKey in user defaults to be pointing to a directory in the temporary directory that is used for testing.[1][2][3][4] This key's value is then set as the cache directory in WebView.mm[5][6]

However, while this key is used to provide application cache location for the Mac port in WebKit2[7], it does not seem to be modified in WebKitTestRunner as it is in DumpRenderTree. I'll ask for some clarification on that in #webkit, but currently it seems that we should mimic what Mac port does (in DumpRenderTree). This could be achieved by setting the XDG_CACHE_HOME environment variable, which would then be returned when application cache directory path is built with calling g_get_user_cache_dir.

[1] http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm#L532
[2] http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm#L484
[3] http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py#L489
[4] http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py#L447
[5] http://trac.webkit.org/browser/trunk/Source/WebKit/mac/WebView/WebView.mm#L592
[6] http://trac.webkit.org/browser/trunk/Source/WebKit/mac/Misc/WebKitNSStringExtras.mm#L330
[7] http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/mac/WebContextMac.mm#L47

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list